Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVOPS-256] Clean up after each job in Windows self-hosted runners #660

Merged
merged 2 commits into from
Aug 22, 2024
Merged

[DEVOPS-256] Clean up after each job in Windows self-hosted runners #660

merged 2 commits into from
Aug 22, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Aug 20, 2024 •
edited
Loading

Todo

  • Make sure crudini is always installed
  • Make sure aerospike server base image is always pulled
  • make sure requirements.txt always installs packages
  • Make sure the right wheel is being installed (i.e the job is cleaning up the repo from the last job)

The "server tag" job that ran after the first job performs all these steps

Extra changes:

  • Fix bug where Windows doesn't test the right server version when specifying to use a server RC or server tag

Regression testing for windows self hosted tests:
Defaults: https://github.com/aerospike/aerospike-client-python/actions/runs/10493831696/job/29068911518
Use server RC: https://github.com/aerospike/aerospike-client-python/actions/runs/10493932203/job/29069188789
Server tag: https://github.com/aerospike/aerospike-client-python/actions/runs/10493931142/job/29069211549

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (856d43d) to head (e2229a9).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #660   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         100      100           
  Lines       15341    15341           
=======================================
  Hits        12477    12477           
  Misses       2864     2864

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review August 21, 2024 19:40
justinlee-aerospike
justinlee-aerospike approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@juliannguyen4 juliannguyen4 merged commit 09f2eb4 into dev Aug 22, 2024
523 of 639 checks passed
@juliannguyen4 juliannguyen4 deleted the DEVOPS-256-hcp-terraform branch August 22, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinlee-aerospike justinlee-aerospike justinlee-aerospike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliannguyen4 @codecov-commenter @justinlee-aerospike